Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding files for Managed Instances, Managed Databases, and Instance Failover Groups #4244

Merged
merged 7 commits into from
Apr 18, 2018
Merged

Adding files for Managed Instances, Managed Databases, and Instance Failover Groups #4244

merged 7 commits into from
Apr 18, 2018

Conversation

jugeorge
Copy link
Contributor

@jugeorge jugeorge commented Apr 18, 2018 •
edited
Loading

Description

These are the generated files (and corresponding tests) for Managed Instances, Managed Databases, and Instance Failover Groups. These were merged in with the following PRs:

Azure/azure-rest-api-specs#2706
Azure/azure-rest-api-specs#2615
Azure/azure-rest-api-specs#2892

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few minor changes.

src/SDKs/SqlManagement/Management.Sql/Generated/SdkInfo_SqlManagementClient.cs
@@ -31,7 +31,10 @@ internal static partial class SdkInfo
new Tuple<string, string, string>("Sql", "FailoverGroups", "2015-05-01-preview"),
new Tuple<string, string, string>("Sql", "FirewallRules", "2014-04-01"),
new Tuple<string, string, string>("Sql", "GeoBackupPolicies", "2014-04-01"),
new Tuple<string, string, string>("Sql", "InstanceFailoverGroups", "2017-10-01-preview"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /t:build /p:Scope=SDKs\SqlManagement and commit any artifacts that may be generated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new files were generated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should have some changes
https://github.com/jugeorge/azure-sdk-for-net/blob/8862cab86643c1c7dadf6228ceba37c277d87332/src/SDKs/SqlManagement/AzSdk.RP.props

src/SDKs/SqlManagement/Sql.Tests/Utilities/SqlManagementTestContext.cs Outdated
@@ -92,6 +92,35 @@ public Server CreateServer(ResourceGroup resourceGroup, string location)

return v12Server;
}

public ManagedInstance CreateManagedInstance(ResourceGroup resourceGroup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please fix indentation
in other places too

src/SDKs/_metadata/sql_resource-manager.txt Outdated
Type dsc to start/install the DS Consolidated Console

2018-04-06 18:59:06 UTC
2018-04-18 15:16:26 UTC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda when I try and run the generate.ps1 file I've added, I get "Could not find module: C:\azure-sdk-for-net\tools\SdkBuildTools\psModules\CodeGenerationModules\generateDotNetSdkCode.psm1. Please run msbuild build.proj to install the module." However, this file is in the folder and the msbuild is passing. Any ideas why?

dsgouda
dsgouda approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to builds passing.

@dsgouda
Copy link
Contributor

dsgouda commented Apr 18, 2018

Overriding CI since last commit should not have any effect

@dsgouda dsgouda merged commit e78b93f into Azure:psSdkJson6 Apr 18, 2018
@jaredmoo jaredmoo mentioned this pull request Apr 24, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jugeorge @dsgouda